HICalSoft / OpenAdhan

Open Source Adhan Application for Windows
GNU General Public License v3.0
6 stars 1 forks source link

OpenAdhan Installer should Automatically Find And Close OpenAdhanForWindows.exe Process #10

Open iysaleh opened 5 months ago

iysaleh commented 5 months ago

Similar to #4 but this is an enhancement, not necessarily a bug. ( #4 was caused by an actual failure to shutdown bug. )

OpenAdhan installer should automatically find and close OpenAdhanForWindows.exe process!

Users currently must manually exit OpenAdhan before the installer runs or they get an install error (see below) --- that's lame and potentially confusing.

323044655-72399ddd-7fca-4d91-a3a5-cbca5d77affa

iysaleh commented 5 months ago

If the installer can kill old OpenAdhanForWindows.exe processes, you no longer need to include the annoying disclaimer in your release notes!

Note: Please make sure any older versions of OpenAdhan are closed before installing newer versions. If previously running V1.0.4 or older, you need to use Task Manager to kill the old OpenAdhan process (see https://github.com/HICalSoft/OpenAdhan/issues/4 )
iysaleh commented 5 months ago

Not possible with InstallForge as of today ... Would need to utilize another installer.

Those were a real pain to figure out... Good thing Github Copilot exists now!!!! 😝

iysaleh commented 5 months ago

Maybe try: https://dennisbareis.com/makemsi.htm https://makemsi-manual.dennisbareis.com/quickstart.htm

Reddit echoes how much a PITA figure out how to build application packagers are: https://www.reddit.com/r/SCCM/comments/a9ybr7/how_to_create_your_own_msi_installer/?rdt=44137