Closed js850 closed 10 years ago
Oh, I forgot to mention that the very minor bug was in DefaultChooser
where grid_size
and grid_seed
were not being used.
Thanks Jacob! Yes, this repo is in dire need of better documentation. Thanks for doing this! I'll review this as soon as I can (along with @mgelbart and @kswersky).
In the meantime, in order to pull this in we'd need you to agree to the contributor license agreement. If you agree could you indicate that you do in this thread?
I agree to the contributor license agreement.
I will review your changes soon and get back to you. Thanks for contributing all this useful documentation!
After seeing Jasper Snoek talk in cambridge I was inspired to try this bayesian optimization package. It seems well written and well commented, but without much documentation. I had a some difficulty trying to understand what all the variables meant and what all the routines were doing. So while I was going through the code in detail I added some documentation for my own benefit. Maybe you guys will appreciate it. But please go over my documentation carefully. The only thing worse then no documentation is incorrect documentation.
I also made some other changes.
tasks
referred to a list ofTask
objects or a list of task names (strings). This confused me a lot and I only changed a few of the examples.Finally, thanks for the great code