search

HIPS / pgmult

Dependent multinomials made easy: stick-breaking with the Pólya-gamma augmentation
MIT License
59 stars 22 forks source link

Python 3 compatibility: print function, absolute imports, ... #5

Closed ariddell closed 9 years ago

ariddell commented 9 years ago

'stage1' automatic conversion from python-future

mattjj commented 9 years ago

Does this commit run under Python 2? I'm afk for an hour or so and I can't test it.

What else needs to be done for Python 3 compatibility?

ariddell commented 9 years ago

Target is code that's 2.7 and 3 compatible. Seems to be working fine for me now in Python 3. The tests, such as they are, seemed to work fine under Python 2.7.

Thanks for the library. This is really handy.

slinderman commented 9 years ago

Thanks! I tested it on 2.7 as well and didn't have any trouble. Glad you're finding it useful!

mattjj commented 9 years ago

By the way, we have a DTM implementation in the dtm branch. We haven't tested it thoroughly or compared it to the variational EM method yet, so it hasn't been rolled into master, but I figured you might be interested in it!

ariddell commented 9 years ago

I saw that! I've linked to pgmult from my aborted attempt to get pg-DTM working https://github.com/ariddell/horizont

On 07/09, Matthew Johnson wrote:

By the way, we have a DTM implementation in the dtm branch. We haven't tested it thoroughly or compared it to the variational EM method yet, so it hasn't been rolled into master, but I figured you might be interested in it!

Reply to this email directly or view it on GitHub: https://github.com/HIPS/pgmult/pull/5#issuecomment-119893033