search

HISKP-LQCD / hadron

R package implementing analysis tools for lattice QCD
15 stars 13 forks source link

cleanup commit in urbach/hadron breaks onlinemeas #12

Closed kostrzewa closed 7 years ago

kostrzewa commented 7 years ago

The removal of getCor (cfunction.R) breaks some functionality. While I use this functionality regularly, maybe it would be better if I rewrite onlinemeas (or move away from it in my analysis routines). What do you think?

kostrzewa commented 7 years ago

6ef3c9fc5c47180a74e608ee471266afe07aaffe

kostrzewa commented 7 years ago

@urbach this also breaks the computation of bootstrap errors... I think we either need to fix this, or I need to take a (few) day(s) off to rewrite and improve the HMC analysis code...

urbach commented 7 years ago

@urbach this also breaks the computation of bootstrap errors... I think we either need to fix this, or I need to take a (few) day(s) off to rewrite and improve the HMC analysis code...

I should fix it...!

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/etmc/hadron/issues/12#issuecomment-279731903

Carsten Urbach e-mail: curbach@gmx.de urbach@hiskp.uni-bonn.de Fon : +49 (0)228 73 2379 skype : carsten.urbach URL: http://www.carsten-urbach.eu

urbach commented 7 years ago

okay, first of all I have added getCor back in. Its currently not a public function, but accessible from within hadron. Do you need it exported?

urbach commented 7 years ago

@urbach this also breaks the computation of bootstrap errors...

what exactly do you mean with breaks the computation of bootstrap errors?

-- Carsten Urbach e-mail: curbach@gmx.de urbach@hiskp.uni-bonn.de Fon : +49 (0)228 73 2379 skype : carsten.urbach URL: http://www.carsten-urbach.eu

urbach commented 7 years ago

@kostrzewa I think I have fixed this now in my master branch, could you confirm!?

kostrzewa commented 7 years ago

what exactly do you mean with breaks the computation of bootstrap errors?

I was referring to onlinemeas with bootstrap errors (in addition to or instead of uwerr)

I think I have fixed this now in my master branch, could you confirm!?

I'll take a look, shouldn't be long.

kostrzewa commented 7 years ago

In your master, could you also add getorderedconfignumbers to the exported functions? I read the online correlators directly now, which is somewhat slow, but it doesn't require the intermediate stage of putonlinetogether.sh. Down the line, it might be worth investigating if the concatenation can be done efficiently from within R.

urbach commented 7 years ago

done

-- Carsten Urbach e-mail: curbach@gmx.de urbach@hiskp.uni-bonn.de Fon : +49 (0)228 73 2379 skype : carsten.urbach URL: http://www.carsten-urbach.eu

kostrzewa commented 7 years ago

Works perfectly, thanks!