search

HISKP-LQCD / sLapH-contractions

Stochastic LapH contraction program
GNU General Public License v3.0
3 stars 3 forks source link

Remove “+” from diagram names #38

Closed martin-ueding closed 6 years ago

martin-ueding commented 6 years ago

Branch: remove-plus_GH-38

The charged diagrams (whose notion has to be discussed anyway) have a c or a + in their name, depending on the place used. It would be more consistent to have the c everywhere. This will break analysis scripts, which are easily updated but perhaps not that easily adapted to handle both variants.

How shall we proceed here? Just replace all the + with c and then see how much this breaks in analysis scripts?

martin-ueding commented 6 years ago

I have removed all the + from the names and replaced them with c. Now it is consistent within the code, but it will require a lot of changes in other places:

This will require changes in all our analysis codes. To make it easier, I could write a little Program that renames the generated files and renames the data set names. This should make a smooth transition and allow to unify existing data with data generated once this is merged.

Is that a suitable plan, or do you rather want to keep the names as they are?

martin-ueding commented 6 years ago

The names are changed now. There is a Python 3 script migrate-plus in the root directory of the repository which will migrate .h5 and .ini (or .in if you have used that) files and updates the diagram and data set names for you. Beware that this is done in place, so you will need to do backups yourself.