HITK-TECH-Community / Community-Website

Official Website of HITK Tech Community 👩🏻‍💻👨🏻‍💻
https://hitk-tech-community.netlify.app/
MIT License
170 stars 320 forks source link

[Frontend] Fix the carousel section of homepage #101

Closed Kajol-Kumari closed 3 years ago

Kajol-Kumari commented 3 years ago

Currently the carousel section have very large image height. Fix it to better smaller sized posters content

Screenshot from 2020-12-28 12-50-42

shraddha-amber commented 3 years ago

I would like to work on this for DWOC. Can you please assign this to me?

codewithvk commented 3 years ago

Capture

@Kajol-Kumari Check it. If you would to like then I will made PR

Kajol-Kumari commented 3 years ago

@shraddha-1402 you can go ahead with this issue and @codewithvk it's a request that don't start working on any issue until you get assigned and as we are following FCFS so I am assigning this to @shraddha-1402 :)

shraddha-amber commented 3 years ago

image

Does this suffice your needs? Require suggestion.

Kajol-Kumari commented 3 years ago

yes @shraddha-1402! Just make sure it doesn't leave any blank space and the cycle continue from 1st poster, once it reaches the last one

shraddha-amber commented 3 years ago

yes @shraddha-1402! Just make sure it doesn't leave any blank space and the cycle continue from 1st poster, once it reaches the last one

yes, it is the same as you are asking

shraddha-amber commented 3 years ago

should i try to make it responsive for mobile?

Abhishek971999 commented 3 years ago

should i try to make it responsive for mobile?

@shraddha-1402 Yes. Please make sure whatever designs you are making, try to make everything mobile-friendly as well.

shraddha-amber commented 3 years ago

should i try to make it responsive for mobile?

@shraddha-1402 Yes. Please make sure whatever designs you are making, try to make everything mobile-friendly as well.

okay, on it!

shraddha-amber commented 3 years ago

i've made the carousel responsive. image image image

Kajol-Kumari commented 3 years ago

@shraddha-1402 Looks good to me :)

shraddha-amber commented 3 years ago

@shraddha-1402 Looks good to me :)

So should i make a pr?

Kajol-Kumari commented 3 years ago

@shraddha-1402 Looks good to me :)

So should i make a pr?

Yes @shraddha-1402 go ahead and make the PR

shraddha-amber commented 3 years ago

@Kajol-Kumari @Abhishek971999
I forked the recent snapshot of the repo and got the same issue, even without adding my code in it. image

Whereas in the previous snapshot on which I worked, the button was perfect. So to check where the issue might be, I compared the dependencies of both the forks and found

"semantic-ui-css": "^2.4.1",
"semantic-ui-react": "^2.0.1", 
"styled-components": "^5.2.1",

these 3 dependencies were added. Maybe there are some conflicts ??

To get snapshot of my commit from old fork I used:-

git init
git remote -v
git remote add origin https://github.com/HITK-TECH-Community/Community-Website.git
git remote -v
git fetch origin e0c0b2b0b52ec40d662e0e509d38d9e9f07435e0      
git reset --hard FETCH_HEAD
cd frontend/
npm install
npm start

And it works as given in this image image

Kajol-Kumari commented 3 years ago

@shraddha-1402 I see.. Do one thing, remove the blue background from the arrow keys and make the arrow keys blue and on hover, make it white.

shraddha-amber commented 3 years ago

@shraddha-1402 I see.. Do one thing, remove the blue background from the arrow keys and make the arrow keys blue and on hover, make it white.

okay! working on it!