Closed Kajol-Kumari closed 3 years ago
I would like to work on making a better login page(DWOC Participant)
Sure @the-supernova go ahead with this issue. Looking forward to your PR :)
Can i also work on this ?
Hey @shraddha-1402 sure. You can also work on this!
I'm new to React...I couldn't find how to make changes to the login button( I tried tweaking loginBtn class and State)..could you guide me in this?
I'm new to React...I couldn't find how to make changes to the login button( I tried tweaking loginBtn class and State)..could you guide me in this?
Hey @the-supernova go to this file and in here we are using bootstrap so you need to do change sin here and see if you are getting the desired output
I'm new to React...I couldn't find how to make changes to the login button( I tried tweaking loginBtn class and State)..could you guide me in this?
Hey @the-supernova go to this file and in here we are using bootstrap so you need to do change sin here and see if you are getting the desired output
I'm there itself, trying to tweak the loginBtn class...I'm not able to resize the login button
Is this login page okay? or should i make any other changes?
@the-supernova @the-supernova Try making a complete new login component with the fields same as we have now and you can take a look at contact
page for the look reference :)
Is this login page okay? or should i make any other changes?
@Kajol-Kumari please give suggestions
Is this login page okay? or should i make any other changes?
@Kajol-Kumari please give suggestions
@shraddha-1402 try to make a new design discarding this one. You can check out the contact page for inspiration and build something similar to that if you like or if you have something even better go ahead with that.
Is this login page okay? or should i make any other changes?
@Kajol-Kumari please give suggestions
@shraddha-1402 try to make a new design discarding this one. You can check out the contact page for inspiration and build something similar to that if you like or if you have something even better go ahead with that.
okay, working on it now!
Can I work on this issue??
Sure @Amit366 go ahead with this issue
can i work on this issue
Hi, can I contribute to this issue as a part of SWOC-21 ?
Hey @kenkirito asyou are already working on two major issues, I request you to finish them first. @vaishnavirshah you can go ahead with this issue :)
Does this login page design look good? should i send pr?
Yes @shraddha-1402 looks great! go for making the PR
@Kajol-Kumari This is the login page I have designed, similar to the contact us page. Since I am not familiar with react, I couldn't do it in the frontend folder and have separately created it. I have used bootstrap for this and have made it responsive using it. If you could guide me how to implement it in the website it will be great!
@vaishnavirshah looks nice just the form needs a bit of enhancement. For the coding part, I would recommend you to take help from already written code of login form. Pull the latest changes and go through the code once by parallely runing it. you would be able to see which part is doing what and similarly you can implement your design
This is the login page I have designed.
Normal:
Hover over submit:
Are there any changes I should make or should I make a PR?
Hey @vaishnavirshah this design looks nice, just make the input fields similar to the fields we have in contact-us
page and also keep the submit
button similar to the contact-us
page in order to be consistent. Also I request you to make a folder by your name under auth
folder and keep all your login code in there in order to avoid the conflict.
Is this fine?
Yes! @vaishnavirshah looks nice and clean. You can make the PR now
@Kajol-Kumari For SWOC if I make PR today will it get counted or should I make it tomorrow?
Make it tomorrow, just to be on safe side :)