HIllya51 / LunaHook

Visual Novel Text Hook Engine / LunaTranslator 核心文本提取器
https://lunatranslator.xyz/
GNU General Public License v3.0
210 stars 14 forks source link

Doesn't load saved user hook #11

Closed SnowLynnx closed 2 months ago

SnowLynnx commented 2 months ago

I insert user hook, select "Remember Hook Selection" for it, select autoattach in settings, close LunaHook and lauch it again, it autoattaches to VN and loads only default hooks, without the userhook that I added (even though the hook is saved in config file). Mentioned above is for LunaHost32. As for LunaHost64, if I use "Remember Hook Selection" and have the autoattach setting on, the app crashes right after the launch (if I delete saved hook from config file it launches fine again)

HIllya51 commented 2 months ago

It is supported now. But actually, I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support. This will also make it more convenient for people who play the same game in the future.

SnowLynnx commented 2 months ago

Thanks, now it loads the hook correctly, but I still have the issue with LunaHost64 crashing on launch. Now it seems to be because of textractor plugins that I added. It launches fine if I remove them. 32 version launches fine with the same plugins. Here's the list: image

Also, would be great if it saved not just one hook, but the state of all hooks as textractor does. In textractor I usually remove the hooks that I don't need and leave only 1-2 that I need, save it, and textractor doesn't load the hooks that I removed.

SnowLynnx commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.

https://vndb.org/v23466 https://vndb.org/v21857

HIllya51 commented 2 months ago

Thanks, now it loads the hook correctly, but I still have the issue with LunaHost64 crashing on launch. Now it seems to be because of textractor plugins that I added. It launches fine if I remove them. 32 version launches fine with the same plugins. Here's the list:

It works fine and not crash for me

屏幕截图 2024-04-16 145234
HIllya51 commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.我更建议你告诉我不能自动挂钩的游戏,这样我就可以将它们添加到内置支持中。

https://vndb.org/v23466 https://vndb.org/v21857

https://github.com/HIllya51/LunaHook/commit/59bf949a129e46ce163e77dcbeb48b1d9582db7e these two games are already build-in 2.10.1 (actually in 2.10.0 they are suppored, I supported them without release a new version number)

SnowLynnx commented 2 months ago

Thanks, now it loads the hook correctly, but I still have the issue with LunaHost64 crashing on launch. Now it seems to be because of textractor plugins that I added. It launches fine if I remove them. 32 version launches fine with the same plugins. Here's the list:

It works fine and not crash for me 屏幕截图 2024-04-16 145234

Maybe your settings are different? I have these: image

HIllya51 commented 2 months ago

all same.

SnowLynnx commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.我更建议你告诉我不能自动挂钩的游戏,这样我就可以将它们添加到内置支持中。

https://vndb.org/v23466 https://vndb.org/v21857

59bf949 these two games are already build-in 2.10.1 (actually in 2.10.0 they are suppored, I supported them without release a new version number)

It inserts some hooks, but none of them contains the text from the VN

HIllya51 commented 2 months ago

Well, it doesn’t matter. Since Host32 can be used, you can just use Host32. There is no difference between the two Hosts.

HIllya51 commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.我更建议你告诉我不能自动挂钩的游戏,这样我就可以将它们添加到内置支持中。

https://vndb.org/v23466 https://vndb.org/v21857

59bf949 these two games are already build-in 2.10.1 (actually in 2.10.0 they are suppored, I supported them without release a new version number)

It inserts some hooks, but none of them contains the text from the VN

Maybe we are using different release, I have tested OK on official release.

SnowLynnx commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.我更建议你告诉我不能自动挂钩的游戏,这样我就可以将它们添加到内置支持中。

https://vndb.org/v23466 https://vndb.org/v21857

59bf949 these two games are already build-in 2.10.1 (actually in 2.10.0 they are suppored, I supported them without release a new version number)

It inserts some hooks, but none of them contains the text from the VN

Maybe we are using different release, I have tested OK on official release.

I used v2.10.1, which seems to be the latest one

SnowLynnx commented 2 months ago

Well, it doesn’t matter. Since Host32 can be used, you can just use Host32. There is no difference between the two Hosts.

As I see, LunaHook32 compatible with both 32x and 64x VNs, so I guess I will do just that. I remember textractor cannot hook 64x VNs from 32x version

HIllya51 commented 2 months ago

I more suggest that you tell me the games that cannot be automatically hooked, so that I can add them to the built-in support.我更建议你告诉我不能自动挂钩的游戏,这样我就可以将它们添加到内置支持中。

https://vndb.org/v23466 https://vndb.org/v21857

59bf949 these two games are already build-in 2.10.1 (actually in 2.10.0 they are suppored, I supported them without release a new version number)

It inserts some hooks, but none of them contains the text from the VN

Maybe we are using different release, I have tested OK on official release.

I used v2.10.1, which seems to be the latest one

I say the release of VN. I have tested all OK of these two vn. Well, it doesn’t matter.

HIllya51 commented 2 months ago

Well, it doesn’t matter. Since Host32 can be used, you can just use Host32. There is no difference between the two Hosts.

As I see, LunaHook32 compatible with both 32x and 64x VNs, so I guess I will do just that. I remember textractor cannot hook 64x VNs from 32x version

Yes, this is an another improvement over Textractor.

SnowLynnx commented 2 months ago

Also, would be great if it saved not just one hook, but the state of all hooks as textractor does. In textractor I usually remove the hooks that I don't need and leave only 1-2 that I need, save it, and textractor doesn't load the hooks that I removed.

@HIllya51 what about this?

HIllya51 commented 2 months ago

It seems to make no sense. Is there any disadvantage of keeping all of hook?

SnowLynnx commented 2 months ago

Sometimes VNs have hooks that constantly spam a lot of text in some threads and it seems to impact the PC performance. I usually play VNs on low spec laptop though.

HIllya51 commented 2 months ago

Textractor seems not support auto remove hook, so I will not support too. If you want auto remove useless hooks, you can use LunaTranslator

HIllya51 commented 2 months ago

actually , even not remove useless hooks, it only spend a few MB extra memory.