search

HJLebbink / asm-dude

Visual Studio extension for assembly syntax highlighting and code completion in assembly files and the disassembly window
MIT License
4.12k stars 97 forks source link

Missing keywords #93

Closed alekasm closed 5 years ago

alekasm commented 5 years ago

Would be nice to have the following keywords added, color-coding not necessary:

-ADDR -OFFSET -NEAR -FAR

HJLebbink commented 5 years ago

Adding these keywords for color-coding is easy, but other features are more complicated. What features that are useful were you thinking of?

alekasm commented 5 years ago

Just the keywords for now would be nice for completeness; you already included everything else. Perhaps error checking ADDR/OFFSET when you use/don't use it inside an INVOKE.

Thanks @HJLebbink

Leaeaxedx commented 5 years ago

Asm instruction vptest is not highlighted in latest asm.

HJLebbink commented 5 years ago

@Leaeaxedx vptest is not an instruction as far as i know. Could you point me to an official documentation with that instruction?

Leaeaxedx commented 5 years ago

At https://software.intel.com/en-us/articles/intel-sdm#combined

you can get Combined Volume Set of Intel® 64 and IA-32 Architectures Software Developer’s Manuals https://software.intel.com/en-us/articles/intel-sdm#combined, April 2019.

I extracted and attached the page regarding PTEST instruction. VPTEST is a part of AVX and AVX 2 instruction set.

V V tor., 14. maj 2019 ob 23:27 je oseba Henk-Jan Lebbink < notifications@github.com> napisala:

@Leaeaxedx https://github.com/Leaeaxedx vptest is not an instruction as far as i know. Could you point me to an official documentation with that instruction?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HJLebbink/asm-dude/issues/93?email_source=notifications&email_token=AIKLMMEXA7K3SGS7AAZIVJTPVMVE5A5CNFSM4GJSHCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVM2YUQ#issuecomment-492416082, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKLMMHDNKGWKGG3BC4IN6DPVMVE5ANCNFSM4GJSHCVA .

HJLebbink commented 5 years ago

Yes, of course. Thanx for pointing that out. Will be fixed!

Leaeaxedx commented 5 years ago

No, THANK YOU for the ASMDUDE!!!!

V V sre., 15. maj 2019 ob 12:06 je oseba Henk-Jan Lebbink < notifications@github.com> napisala:

Closed #93 https://github.com/HJLebbink/asm-dude/issues/93.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HJLebbink/asm-dude/issues/93?email_source=notifications&email_token=AIKLMMDTRMOJONCRBOTI5VLPVPOCZA5CNFSM4GJSHCVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOROR62VQ#event-2342776150, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKLMMHOH2UJD5S3ZEG4QMDPVPOCZANCNFSM4GJSHCVA .

HJLebbink commented 5 years ago

@Leaeaxedx I'm a bit confused. Do you have an assembler that accepts vptest as an instruction? The documentation only gives opcodes for VPTESTMB, VPTESTMW, VPTESTMDand VPTESTMQ.

Leaeaxedx commented 5 years ago

I'm using Uasm assembler ( http://www.terraspace.co.uk/uasm.html)

There is attached testing disassembly for VPTEST instruction. The instruction is from AVX architecture and It works on my I7 from 2010. VPTEST sets Z flag if the result of bitwise AND is zero. The instructions VPTESTMB, VPTESTMW, VPTESTMD are from AVX512 architecture. They set the mask according to bitwise AND result.

[image: Dissasembler.png] I also attached VPTEST manual page from "Intel® 64 and IA-32 Architectures Software Developer's Manual" all volumens (A;B...)

Hope this will help you a bit. Don't hesitate to contact me again.

Have a nice coding! ;)

V V ned., 26. maj 2019 ob 15:43 je oseba Henk-Jan Lebbink < notifications@github.com> napisala:

@Leaeaxedx https://github.com/Leaeaxedx I'm a bit confused. Do you have an assembler that accepts vptest as an instruction? The documentation only gives opcodes for VPTESTMB, VPTESTMW, VPTESTMD and VPTESTMQ.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HJLebbink/asm-dude/issues/93?email_source=notifications&email_token=AIKLMMEGKPB2LQCB6ZSPYQLPXKHYZA5CNFSM4GJSHCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIGD2Y#issuecomment-496001515, or mute the thread https://github.com/notifications/unsubscribe-auth/AIKLMMGJEU27S2KMOJTXALTPXKHYZANCNFSM4GJSHCVA .

Leaeaxedx commented 3 years ago

FYI: The AsmDude recognizes VPSHLB (W/D/Q) as AVX instructions, which are not valid instructions.

Regards,

Igor