Fix encoded values map attribute

HK3-Lab-Team / pytrousse

PyTrousse collects into one toolbox a set of data wrangling procedures tailored for composing reproducible analytics pipelines.

Apache License 2.0

0 stars 1 forks source link

Fix encoded values map attribute #105

Closed lorenz-gorini closed 3 years ago

lorenz-gorini commented 3 years ago

Add extra padding to the first and last bin. This is to include possible future/test set sample values.
Fixed the self.encoded_values_map initialization
Replaced logger instantiations with unique root Logger instance. This avoids the creation of multiple logging instances for each module. (see issue #104 for a possible future improvement of this)
Replaced few print calls with logging.info

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 94d4f4304eb178556c9b6120b262c25bed71ecef into 82871fe714c8d98ee7d1d818982622df24ace546 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

alessiamarcolini commented 3 years ago

-1.2% coverage is too much (we have the threshold set at -1%).. can you test something at least? 🙏🏽

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 9b7c600ec657f0d074acc0bbd48e649081d82875 into 82871fe714c8d98ee7d1d818982622df24ace546 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call