search

HKDAQ / FLOWER

soFtware for LOW-Energy Reconstruction
4 stars 8 forks source link

CI workflows disabled #29

Open JostMigenda opened 3 months ago

JostMigenda commented 3 months ago

The CI workflows added in #26 are failing, because they require repository secrets which are not currently set. I have disabled them for now.

@guiguem: Currently @brichards64 is the only admin of the HKDAQ org, and thus afaict the only person able to configure secrets for this repository. Can you discuss the configuration with Ben before we re-enable the workflows?

guiguem commented 3 months ago

Right! I think if one wants to use this software for production in the near future, this should be transitioned to the hyperk organisation where we can ensure proper maintenance. Do you see any issues with this move (e.g. software or copyright wise)? If not, then we should discuss with Ben about doing this and then we can update the secrets etc...

JostMigenda commented 3 months ago

Since using FLOWER necessarily requires a vertex fitter like hk-BONSAI or LEAF—which are both already located under the hyperk org!—I don’t see any issues with that move, no. Whereas having it under a different org than other sim/reco packages is clearly causing issues.

GitHub is very good about forwarding any URLs referencing a transferred repo, so this shouldn’t cause much of a migration burden, either.

(For historical context: The reason we moved it to the HKDAQ org in May 2020—it was under my personal account before that—was because we inside the DAQ group were discussing how to integrate it into a SN trigger (see #10); we didn’t think much about whether another org may be a better choice.)

JostMigenda commented 3 weeks ago

We talked about this earlier today at the HK UK PSC meeting and agreed that @brichards64 will move the repo to the hyperk org. Then you and @sk1806 will be able to admin the repo as needed, create new tags for HK software releases, etc.