Using Route's render prop instead of component prop for src/pages/App.

netlify[bot] commented 4 years ago

Deploy preview for hkn-portal-staging ready!

Built with commit 4d30f0c8edb26af84736ccf08ad7eb7562e2b261

https://deploy-preview-114--hkn-portal-staging.netlify.app

godwinpang commented 4 years ago

nice work - would love it if there's some explanation as to why we did this :) I think it would be good not only for education purposes but also for documentation

thai-truong commented 4 years ago

Yeah mb about that. I did write some explanation in the issue description but I'll just put it here as well.

The reason why we are switching from component prop to render prop for Route in src/pages/App is because:

When using component prop, mounting and unmounting of the React component/page that the Route points to happens at every re-render. Using the render prop prevents this from happening, which will improve the performance/speed of the webapp (since (un)mounting is expensive). Also, we get smaller stack trace for (memory leak) errors if we use render prop, meaning it's a lot easier to identify where the (memory leak) errors are coming from.

HKN-UCSD / old-hkn-server

Using Route's render prop instead of component prop for src/pages/App. #114