Is there a bug in "decode_GPS_subframe"?

HKUST-Aerial-Robotics / ublox_driver

A driver for u-blox receiver (ZED-F9P) with ros support

GNU General Public License v3.0

96 stars 44 forks source link

Is there a bug in "decode_GPS_subframe"? #20

Closed Steph00L closed 2 months ago

Steph00L commented 2 months ago

I notice that when "Set bits to subframe buffer", subfrm[ephem->sat] is used instead of subfrm[ephem->sat - 1]. I also observed that 'subfrm[ephem->sat - 1]' is used in other systems(Galileo,BeiDou,GLONASS). Could this be an indexing error? Thanks~

shaozu commented 2 months ago

Hi, @Steph00L. Indeed it's an indexing error. The bug has been fixed and thanks for pointing this out!