search

HKUST-KnowComp / R-Net

Tensorflow Implementation of R-Net
MIT License
578 stars 210 forks source link

filter out long examples should only in train and test #61

Closed ZizhenWang closed 5 years ago

ZizhenWang commented 5 years ago

i think the following bool expression should contain not is_test right? for test example we should not filter it out, even it exceed the length limit?

https://github.com/HKUST-KnowComp/R-Net/blob/1efc5ef18067a84d44fa8d31c309a19c52958e92/prepro.py#L127-L128

ZizhenWang commented 5 years ago

I miss the is_test matters in setting length limitation, solved.