HL7-DaVinci / CRD

Coverage Requirements Discovery (CRD) Reference Implementation (RI)
Apache License 2.0
31 stars 21 forks source link

NPE with order-select containing ServiceRequest #291

Open nradov opened 1 year ago

nradov commented 1 year ago

When we send an order-select hook request containing a ServiceRequest resource in the draftOrders field we receive back a card with "summary": "Unable to (pre)fetch any supported bundles.".

This code appears to cause a NullPointerException when queryResponseBundle is null. https://github.com/HL7-DaVinci/CRD/blob/master/server/src/main/java/org/hl7/davinci/endpoint/components/QueryBatchRequest.java#L95

Besides the NPE, according to @lmckenzi: "the RI should not be returning a card with a summary like that. Cards should always contain information useful to the end user. If something goes wrong, that's for the log process." https://chat.fhir.org/#narrow/stream/180803-Da-Vinci-CRD/topic/NPE.20in.20CRD.20RI.20Server/near/391302119