HL7 / CDA-core-xsl

Informative stylesheet based on XSLT 1.0 to render all CDA documents
35 stars 20 forks source link

changes in this version #16

Open nizarbs2508 opened 1 year ago

nizarbs2508 commented 1 year ago

For all the elements of the header, the modification is made at the top and at the bottom of the displayed document.

At the top of the document:

At the bottom of the document:

Responsible Party and admitting physician:

Author :

Participant:

Commentaire sur le Dr MEDIONI -> if nullFlavor="NA", it puts "no applicable value" => ok if nullFlavor alone to indicate the label of the nullFlavor -> if nullFlavor + originalText => put only the text (and not "no applicable value") -> same rule on the display order suffix, prefix, first name, last name (with a space between each) + put a line break if functioncode before dataEnterer - same rule on the display order suffix, prefix, first name, last name (with a space between each) - same rule on organization in parentheses. Informant: Address - same rule on the display order suffix, prefix, first name, last name (with a space between each) - display and on the same line - put a line break after use="H" "home", use="WP" "work", etc… - put a line break after each telecom informationRecipient - same rule on the display order suffix, prefix, first name, last name (with a space between each) - display and on the same line Authenticator and legalAuthenticator: - same rule on the display order suffix, prefix, first name, last name (with a space between each) - display and on the same line. + add checks on all array for header and footer elements in case the element is empty
mjszczep commented 1 year ago

Hi Nizar--unfortunately, this commit is a bit hard to read through because of the number of extraneous changes moving line breaks and whitespace around. Is it possible to keep those the same in areas you're not actually modifying?

It's also unclear to me what the goal of some of these changes are. To pick just one example, the behavior of the show-identifiant template seems like a design change that would probably warrant its own discussion; do we need both show-identifiant and show-id-set? Or maybe we should pick one set of consistent behavior (either show ID OIDs or don't) and apply it everywhere. And if in some use cases we want to show ID OIDs everywhere and in others we don't--say, because of differing regulatory requirements--then that might be a good case for a new stylesheet parameter.

Topics like that would also be easier to discuss if your branch were split up into multiple smaller commits, each with its own separate change. That would make it easier to focus on them one at a time and figure out how best to merge them.

If you'd also rather just maintain your own fork on its own, that's fine too, of course! But if we do want to merge these changes into the HL7-released version of the stylesheet, I think we need to at least get rid of the extraneous formatting changes and ideally split it into smaller commits in order to move further along.

If you'd prefer, we can also talk about this on one of the Structured Documents conference calls, every Thursday at 10 AM US Eastern time. Talking on GitHub works too, but it's an option if you feel like a call would help things move faster!

mjszczep commented 1 year ago

Hi Nizar--are there still any changes you think should be merged into HL7's version of the stylesheet (and so released to everybody)? Or are all the changes in your fork specific to your use case at this point? If it's the latter, I figure we can just close this PR.