search

HL7 / US-Core

FHIR R4 version of US Core IG
29 stars 28 forks source link

Clarify language about modifiers, chains, etc #17

Closed jmandel closed 5 years ago

jmandel commented 5 years ago

Multiple pages state:

The following search parameters, search parameter combinations and search parameter modifiers, comparators, chains and composites SHALL be supported. the modifiers, comparators, chains and composites that are listed as optional SHOULD be supported.

At the very least, . the should be . The. But even with that tweak, I'm not sure what's intended; the text seems to state SHALL and then SHOULD in rapid succession, and in many cases I don't even see any modifiers, comparators, chains or composites in the examples themselves. The boilerplate language is unclear.

Healthedata1 commented 5 years ago

This is was all generated using a template and challenging is to describe both where modifier A is a SHALL and modifier B is a SHOULD in words. I did not think using only the syntax was clear enough. any suggestions?

Eric

Eric M Haas, DVM, MS Health eData Inc 1183 Mountain View Circle, Napa, CA 94558 707.227.2608|Skype: haas.eric1 ehaas@healthedatainc.com

On Wed, Aug 21, 2019 at 8:15 AM Josh Mandel notifications@github.com wrote:

Multiple pages state:

The following search parameters, search parameter combinations and search parameter modifiers, comparators, chains and composites SHALL be supported. the modifiers, comparators, chains and composites that are listed as optional SHOULD be supported.

At the very least, . the should be . The. But even with that tweak, I'm not sure what's intended; the text seems to state SHALL and then SHOULD in rapid succession, and in many cases I don't even see any modifiers, comparators, chains or composites in the examples themselves. The boilerplate language is unclear.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HL7/US-Core-R4/issues/17?email_source=notifications&email_token=ABYRJ2USLEIEGDMRCYKSD23QFVL2ZA5CNFSM4IOILV6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGRMWTA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYRJ2X3REF3BJJUG2TSAC3QFVL2ZANCNFSM4IOILV6A .

Healthedata1 commented 5 years ago

reworded. see latest Argo-R4 build:http://build.fhir.org/ig/argonautproject/R4/branches/master/index.html