search

HL7 / fhir-ig-publisher

Source code for the IG publisher
Apache License 2.0
67 stars 55 forks source link

Jurisdiction of ImplementationGuide is over enforced #246

Open RichardTON opened 3 years ago

RichardTON commented 3 years ago

If an ImplementationGuide that has no value for jurisdiction is derived from another that has a jurisdiction, the validator raises a warning e.g.

The resource should declare its jurisdiction to match the package id (hl7.fhir.au.dh.medicare-records, jurisdiction = urn:iso:std:iso:3166#AU) (for FSH: 'jurisdiction: urn:iso:std:iso:3166#AU "null"')

However resources in the derived IG get an error

The resource must declare its jurisdiction to match the package id (hl7.fhir.au.dh.medicare-records, jurisdiction = urn:iso:std:iso:3166#AU) (for FSH: 'jurisdiction: urn:iso:std:iso:3166#AU "null"')

I think that it should be at most a warning. See related Zulip chat https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Jurisdiction.20of.20packages/near/229232412 and IG that has this problem https://build.fhir.org/ig/AuDigitalHealth/ci-medicare-records/qa.html

grahamegrieve commented 3 years ago

can't reproduce?

RichardTON commented 3 years ago

I've just rebuilt this locally with the same results as at https://build.fhir.org/ig/AuDigitalHealth/ci-medicare-records/qa.html

ig.xml has a warning but all of the other resources get an error, e.g. flag-air-1

I think that they should all be warnings.

RichardTON commented 3 years ago

Unless there is a reason why they are different.

RichardTON commented 3 years ago

I expect that an IG can have one jurisdiction which aligns with its package, but that it can include profiles that are not part of its jurisdiction. Is this a mistake?

lmckenzi commented 2 years ago

Agree this should be a warning in both cases. (I.e. not an error)