search

HL7 / fhir-ig-publisher

Source code for the IG publisher
Apache License 2.0
70 stars 57 forks source link

Move the profile terminology rendering binding documentation (and VS URL) under the binding (instead of after the additional binding table #869

Open caspears opened 8 months ago

caspears commented 8 months ago

The binding documentation and the VS url in the Terminology Bindings table seems to appear after the additional Bindings table. As should in the attached image image https://build.fhir.org/ig/HL7/fhir-sdoh-clinicalcare/branches/STU2.2/StructureDefinition-SDOHCC-ObservationScreeningResponse.html#terminology-bindings-1

This is particularly notable when the additional bindings table has a larger number of entries. The documentation for the binding should show up with the binding instead of after the additional bindings table.

lmckenzi commented 8 months ago

Move the "Additional Bindings" table to appear after all text that's talking about the primary binding (i.e. after the canonical URL of the value set and the part that says "from the FHIR Standard" (and after any other bindings it talks about such as max bindings or something, if those aren't already set up to show up in the additional bindings table).

lmckenzi commented 4 days ago

@caspears This no longer looks to be an issue in the snapshot of the CI build. (It looks like the rendering has changed in a few ways.) Can you confirm this is no longer an issue?

caspears commented 4 days ago

Well oddly the additional bindings does not appear at all for my profile defined additional bindings (the base language one does appear, still with the issue like so (with snapshot view under terminology bindings section): image

Here is the table originally, with the profile defined additional bindings table (that had the issue, but at least had the table): https://hl7.org/fhir/us/sdoh-clinicalcare/STU2.2/StructureDefinition-SDOHCC-ObservationScreeningResponse.html#tabs-snap image

Here is the new rendering where the profile defined additional bindings tables do not show up: https://build.fhir.org/ig/HL7/fhir-sdoh-clinicalcare/branches/STU2.3/StructureDefinition-SDOHCC-ObservationScreeningResponse.html#tabs-snap image

lmckenzi commented 4 days ago

When I go here: https://hl7.org/fhir/us/sdoh-clinicalcare/STU2.2/StructureDefinition-SDOHCC-ObservationScreeningResponse.html#tabs-snap I see: image

And when I go here: https://hl7.org/fhir/us/sdoh-clinicalcare/STU2.2/StructureDefinition-SDOHCC-ObservationScreeningResponse.html#tabs-snap I see: image

What browser are you using? (I'm using Chrome on Windows.)

caspears commented 4 days ago

I am using Chrome on Windows as well.

The url base "https://hl7.org/fhir/us/sdoh-clinicalcare/STU2.2" represents how it used to render. The url base "https://build.fhir.org/ig/HL7/fhir-sdoh-clinicalcare/branches/STU2.3" in the links I had in my comment shows how it looks now.

Please note that I am looking at the snapshot tab down in the Terminology bindings section, not the element tree (which your screen shots seem to show based on the fact that each row has alternating background colors). The element tree section looks fine.

lmckenzi commented 4 days ago

https://github.com/HL7/fhir-ig-publisher/pull/986