search

HL7 / fhir-shc-vaccination-ig

FHIR Implementation Guide describing clinical and patient data contained within a SMART Health Card
https://vci.org/ig/vaccination-and-testing
35 stars 18 forks source link

Are the `vc.type` elements in the examples being generated properly? #206

Open jdkizer9 opened 2 years ago

jdkizer9 commented 2 years ago

Scenario 1 bundle (COVID-19 immunization) expanded JWS includes the following type:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#labresult"
    ],

I'd expect this to be:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#immunization",
      "https://smarthealth.cards#covid19"
    ],

Scenario 3 bundle (COVID-19 lab result) expanded JWS includes the same type element as above. I'd expect it to be:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#labresult",
      "https://smarthealth.cards#covid19"
    ],
nkarip commented 2 years ago

Yes, main branch is not correct. We have a fix pending in the dev branch at https://github.com/HL7/fhir-shc-vaccination-ig/tree/dev/examples but this has not yet promoted to main.

p9g commented 2 years ago

See https://github.com/HL7/fhir-shc-vaccination-ig/pull/174 and https://github.com/HL7/fhir-shc-vaccination-ig/issues/172