search

HL7 / fhir-shorthand

FHIR Shorthand
44 stars 8 forks source link

Use curl to test connection. #105

Closed bkaney closed 3 years ago

bkaney commented 3 years ago

Ping / ICMP is sometimes block by firewalls. Update to use the same curl command seen in _genonce.sh

cmoesel commented 3 years ago

Thanks for the PR, @bkaney! This looks good, but we do have a slight problem in that the publisher scripts are self-updating. I can accept this, but next time the script runs, if a user selects to update the script (which is usually what we recommend), then your change will be overwritten.

The real source repository for these scripts is here: https://github.com/HL7/ig-publisher-scripts. I'd actually suggest that you submit a PR against that repository -- then your update will propagate to many more places (including projects created using sushi --init).

bkaney commented 3 years ago

Thanks @cmoesel -- I proposed the same patch in a PR there as well. This would be really great, we are running into problems running in certain VPN settings as ping is blocked.

markkramerus commented 3 years ago

I appreciate the improvement, Brian, but as noted above, Shorthand does not own the publisher scripts. Therefore, I am going to close this request and look for it to be implemented as part of ig-publisher-scripts repository.