HL7 / fhir-shorthand

FHIR Shorthand
44 stars 8 forks source link

FSH 3.0 Resolutions - Overview #175

Closed jafeltra closed 10 months ago

jafeltra commented 10 months ago

This PR contains a batch of changes that were agreed upon as part of the FSH ballot resolution process. These changes are in the overview page. The following Jira issues were addressed:

FHIR-42159: Typo refers to wrong line in example FHIR-42346: Correct spelling of octothorpe FHIR-42299: Clarify target of pronoun FHIR-42360: Data types identical to the one in FHIR R5 FHIR-42361: What is SD? Note: the Jira issue and resolution specifically reference one place "SD" is used. However, I updated a second place in the Overview page that "SD" was used. FHIR-42362: Improve sentence (Aliases) FHIR-42298: Correct alias applicability Note: FHIR-42362 and FHIR-42298 refer to the same sentence. I couldn't make the resolution for one without overwriting the resolution for the other. I did my best to merge the two, but if that is an issue or there's a better way to combine them, let me know. FHIR-42615: Title case should be Upper Camel case Note: The resolution does not include a link, but it does to refer to matching what is stated around the links in 3.3.11, which does include a link to the Upper Camel Case. I have not added the link in the Overview, but if a reviewer disagrees, let me know.

I added a few minor comments about the implementation of the documented resolution. I'll make any updates for those and rebase to keep all the changes in their own commit.

At least one reviewer should review each commit alongside its Jira issue to ensure the resolution was followed. Other reviewer(s) should ensure the content makes sense, there are no typos, etc.

NOTE: This PR should be merged using the rebase strategy to maintain commits.