HL7 / fhircast-docs

FHIRcast documentation
Other
22 stars 20 forks source link

Updating a subscription -- clarify how this works. #287

Open isaacvetter opened 5 years ago

isaacvetter commented 5 years ago

During the HL7 Sept FHIRcast connectathon track, @wmaethner , Bas, and I talked through -

When creating a new subscription for the same topic and callback url as an existing subscription,

Need to clarify that the Hub responds as part of the intent verification with the events that a subscriber is successfully using.

For websockets new subscriptions for the same topic should be on new websocket connections (we think).

gkustas commented 5 years ago

In what scenario would more than one client be sharing the same callback?

wmaethner commented 5 years ago

Hey @gkustas, multiple clients shouldn't have the same callback, it should be unique. The situation we were thinking of was where the client makes a subscription, but then later wants to add or change the events it is subscribed to (e.g. they subscribe to patient events, then later want to also subscribe to study events). In that case it will be the same topic and callback.

gkustas commented 5 years ago

Ahhh. That makes sense. I'll need to check my him implementation to make sure that works

On Sun, Sep 15, 2019, 10:43 AM Will Maethner notifications@github.com wrote:

Hey @gkustas https://github.com/gkustas, multiple clients shouldn't have the same callback, it should be unique. The situation we were thinking of was where the client makes a subscription, but then later wants to add or change the events it is subscribed to (e.g. they subscribe to patient events, then later want to also subscribe to study events). In that case it will be the same topic and callback.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HL7/fhircast-docs/issues/287?email_source=notifications&email_token=ABODZ3VEM7LSFMNUNFAE4N3QJZCY5A5CNFSM4IWXHRD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XSE4Q#issuecomment-531571314, or mute the thread https://github.com/notifications/unsubscribe-auth/ABODZ3WIYGRFUKJOFJGZIJTQJZCY5ANCNFSM4IWXHRDQ .