search

HL7 / ig-template-base

Base IG template managed by HL7 but usable by anyone (no logos). The foundation for most HL7-published IGs
14 stars 27 forks source link

Fix history links - PLEASE VERIFY #111

Closed costateixeira closed 4 years ago

costateixeira commented 4 years ago

changed all xx.history.html to xx.change.history.html, to avoid conflict with automatically generated history fragment. Tested this against an IG that has history on a profile and a valueset.

(Still has issue with examples tab being shown in some layouts, hidden in others)

lmckenzi commented 4 years ago

Not sure how you want me to verify. Have you tested with the IGs that are failing?

costateixeira commented 4 years ago

Yes. I tested with David Hay's and my sample-ig which is the sample-ig but with history for a valueset also. What i did was to change the reference from any fragments xxx.history.html to xxx.change-history.html. If you could see whether my changes are what you would do for that, that should be safe enough to get a round of testing.

On Fri, Jul 17, 2020 at 8:39 PM Lloyd McKenzie notifications@github.com wrote:

Not sure how you want me to verify. Have you tested with the IGs that are failing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HL7/ig-template-base/pull/111#issuecomment-660276459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3HUUGQ3EFGINTUV6NRUFLR4CLGJANCNFSM4O6TZSBA .