search

HL7 / ig-template-base

Base IG template managed by HL7 but usable by anyone (no logos). The foundation for most HL7-published IGs
14 stars 27 forks source link

add liquid to hide empty inv tables #113

Closed Healthedata1 closed 4 years ago

Healthedata1 commented 4 years ago

foo

Healthedata1 commented 4 years ago

this is a liquid solution

lmckenzi commented 4 years ago

The section you highlighted in the diagram wasn't actually empty. I'm not sure we want to hide 'inherited' invariants. Those are still relevant. (Though it would be nice if we could distinguish inherited ones from new/changed ones.)

Healthedata1 commented 4 years ago

what I am illustrating is that when there are constraints the table is rendered and when there are none the table is not rendered. this occur most often when the parameter 

- code: show-inherited-invariants
  value: 'false'
Healthedata1 commented 4 years ago

here is an example of an empty table that would be hidden...

image

lmckenzi commented 4 years ago

So, to clarify, this change will cause empty tables to not appear, but won't prevent inherited invariants from showing, correct? And the default in the base is to always show inherited invariants and the requirement for HL7 IGs would be to always show inherited invariants - correct?

Healthedata1 commented 4 years ago

So, to clarify, this change will cause empty tables to not appear, but won't prevent inherited invariants from showing, correct?

Correct

And the default in the base is to always show inherited invariants and the

requirement for HL7 IGs would be to always show inherited invariants - correct?

I think that is a separate discussion. The parameter 'show-inherited-invariants' exists with default = true and is not prohibitd for use.

Eric

Eric M Haas, DVM, MS Health eData Inc 35 Crescent Avenue, Sausalito, CA 94965 707.227.2608|Skype: haas.eric1 ehaas@healthedatainc.com

On Tue, Jul 28, 2020 at 9:13 AM Lloyd McKenzie notifications@github.com wrote:

So, to clarify, this change will cause empty tables to not appear, but won't prevent inherited invariants from showing, correct? And the default in the base is to always show inherited invariants and the requirement for HL7 IGs would be to always show inherited invariants - correct?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HL7/ig-template-base/pull/113#issuecomment-665133625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYRJ2VUOPA2OYCVM4DGBVLR532L7ANCNFSM4PEJ26EQ .

lmckenzi commented 4 years ago

I think HL7-published IGs need to be consistent about always publishing all invariants. It may be the best solution is to combine the list of invariants into the tabs that show snapshot vs. differential vs. 'mustSupport' so that you can look at the invariants pertinent to the view. But having a published IG that doesn't show all of the invariants is a problem, no matter how noisy they might be.