search

HL7 / ig-template-base

Base IG template managed by HL7 but usable by anyone (no logos). The foundation for most HL7-published IGs
14 stars 27 forks source link

Feedback form #135

Closed costateixeira closed 3 years ago

costateixeira commented 3 years ago

Included fragment-feedback_form.html Created an empty fragment-feedback_form.html otherwise jekyll complains (and there was no simple way to IF that scenario) Added a conditional link at the end of the footer

Tested on a few belgian IGs https://github.com/hl7-be/manzana-ig/

costateixeira commented 3 years ago

@lmckenzi ready to merge

lmckenzi commented 3 years ago

Did we get any feedback on security issues?

costateixeira commented 3 years ago

I did - I should whitelist the variables to make sure nobody can inject code. I'm working on a cleaned version of the form - this is why I left the empty form for now - when I have a robust form I will commit that for a review. This PR creates a stub which I can use to test these next steps. As I think of it, no need to merge. I'll figure out how to handle the variable I'm missing for google forms, and commit then. After that I'll work on Jira form.