search

HL7 / ig-template-base

Base IG template managed by HL7 but usable by anyone (no logos). The foundation for most HL7-published IGs
14 stars 27 forks source link

Fix annoying flicker at page load #153

Closed costateixeira closed 3 years ago

costateixeira commented 3 years ago

change on the element? I don't understand that.

the last commit added back the style on the segment-content. I did remove the onload="document.body.style.opacity='1'" in the tag because I think it doesn't hurt (and because in the past I had some issues with it). it can also be removed but I did not test it

lmckenzi commented 3 years ago

That's what I'm referring to - " " got added in https://github.com/HL7/ig-template-base/pull/114 and you've rolled back most of it, so wondering if we should roll that part back too. If you can try & test, that'd be appreciated.

costateixeira commented 3 years ago

there was a quote missing, thanks. While I'm testing it, I still don't understand what this means:

That's what I'm referring to - " " got added in #114 the only other thing that got loaded is the opacity. I deliberately left it there because of past pain in templates that looked all black. Perhaps that is now harmless, but I left it anyway.

costateixeira commented 3 years ago

but I can remove that change if you want to really go back to the previous state before #114

costateixeira commented 3 years ago

@lmckenzi tested locally (just updated my local package cache accordingly), works (i did not follow the procedure to make a branch, use that branch and download it, because at this time I can't remember that procedure)