HL7 / ig-template-base

Base IG template managed by HL7 but usable by anyone (no logos). The foundation for most HL7-published IGs
14 stars 27 forks source link

Add nav tabs #79

Closed Healthedata1 closed 4 years ago

Healthedata1 commented 4 years ago

this commit adds nav tabs to all the resources as GG requested. it also reduces redundant code by using two include files.

tested on CRD, sample-ig and my test ig.

a couple of screenshots:

navtabs2 navtabs1

lmckenzi commented 4 years ago

I'm fine with the change in principle, but the word "Content" doesn't make sense everywhere. Its "ok" for profiles and perhaps works for code systems and value sets because those resources have content. However, for the example template, it'd be better if the tab just said "narrative" or "human readable" and we dropped the narrative heading. Also, can you make a commit to resolve the conflicts?

Healthedata1 commented 4 years ago

OK will make those changes. I agree but did not want to change the text just apply the tabs everywhere.

Healthedata1 commented 4 years ago

I will make the changes to the tab names and drop the narrative heading first then resolve the conflicts here

lmckenzi commented 4 years ago

Why did you remove the paragraph that indicated the 'id' from the various tabs? The id matters...

Healthedata1 commented 4 years ago

I don't know what you mean, I removed these meaningless redundent paragraphs: removed lines

Healthedata1 commented 4 years ago

the id is still in the h2 header?

Healthedata1 commented 4 years ago

the nav tabs fragments have the includes id variable include.id which == {{[id]}}

<a href="{{include.type}}-{{include.id}}-mappings.html">Mappings</a>

Healthedata1 commented 4 years ago

could also use page variable too like

---
id: {{{id]}}
type: {{[type]}}
---

and then do this instaed:

<a href="{{page.type}}-{{page.id}}-mappings.html">Mappings</a>

Healthedata1 commented 4 years ago

is that what you mean?

lmckenzi commented 4 years ago

Old content was stuff like this: <p>Definitions for the {{[id]}} Extension</p> The h2 doesn't include the id in the rendered text.

(And I don't want us using page variables. They cause issues in XHTML and we want to minimize the complexity of the markdown)

Healthedata1 commented 4 years ago

yes I removed them since the are redundant and add no new information for the reader to experience since they repeat the title. I assumed since you wanted the text 'narrative' removed you want all the meaningless introductory text removed. No matter can put them back.

lmckenzi commented 4 years ago

My concern is that id and title aren't the same. Are you referring to a title appearing somewhere other than the

?

Healthedata1 commented 4 years ago

mmm let me check it out again....

Healthedata1 commented 4 years ago

OK I see ... titles are using {{[title]}} and not {{[id]}} will add back in sorry...

Healthedata1 commented 4 years ago

I will:

  1. close this commit
  2. merge branch with master
  3. create a new PR
  4. redo the conflicts in the PR (since my fork is not syncing correctly )