HL7 / v2-to-fhir

This repository supports tools and content for the V2 to FHIR project.
Apache License 2.0
68 stars 22 forks source link

Deeplinks to FHIR field definitions use the wrong URL. #44

Open bvdh opened 2 years ago

bvdh commented 2 years ago

On page https://build.fhir.org/ig/HL7/v2-to-fhir/ConceptMap-datatype-pl-to-location.html

The following url (pattern) is used to refer to field definitions in FHIR:

https://hl7.org/fhir/R4/Location.Location-definitions.html#Location..identifier

This should be:

https://hl7.org/fhir/R4/location-definitions.html#Location.Identifier

This issues is present for all field definition links on this page and may very well also exist on other pages as well.

hbuitendijk commented 2 years ago

@bvdh : Thank you for catching that. We use in our mapping spreadsheets the notation "[1].identifier" to indicate indicate that the resource yields a different instance (see here for original source: https://docs.google.com/spreadsheets/d/17b4wqJOzGieNBSdHYZt3ymKucsRDd_h8leaiz_umG7E/edit#gid=0). That mapping is not yet finished, but you can see each room, bed, facility, etc. needs to yield a different Location resource, that are then linked/chained. Normally that column does not have a "." in front, but this syntax actually does so. We'll have to figure out whether to make the parser sensitive to "[n]." to not turn that into an extra dot, but in this case it should be "Location[1].identifier". @keithboone : What is the easiest path? Change the syntax in the spreadsheet? Or change the parser? I'd rather go with the latter.