search

HL7Norway / basisprofiler-r4

HL7 FHIR Base profiles for Norway - R4
https://simplifier.net/guide/no-basis-entities-individuals
17 stars 2 forks source link

no-basis-procedure: minor updates after TSC review #91

Closed mmsmits closed 2 years ago

mmsmits commented 2 years ago
thomiz commented 2 years ago

There are some missing points according to our checklist: best-practice/no-basis-checklist.md at master · HL7Norway/best-practice (github.com)

There are quite a few elements that are profiled, that lack (written) documentation about the changes made to the resource (and the reason for the change).

Can you please also update the changelog file for the project?

We also need some md files we can add to the implementation guide: https://simplifier.net/guide/no-basis-Entities-Individuals/Introduction

mmsmits commented 2 years ago

There are some missing points according to our checklist: best-practice/no-basis-checklist.md at master · HL7Norway/best-practice (github.com)

There are quite a few elements that are profiled, that lack (written) documentation about the changes made to the resource (and the reason for the change).

Can you please also update the changelog file for the project?

We also need some md files we can add to the implementation guide: https://simplifier.net/guide/no-basis-Entities-Individuals/Introduction

I added an example, and commented a bit more in the changes, also updated the changelog.

Where should I put the .md files, and what should it contain? Btw, the guidelines are in Norwegian, if you miss something specific, please let me know or feel free to add it yourself.

thomiz commented 2 years ago

I will replace with a feature branch pull request

thomiz commented 2 years ago

Thanks a lot @mmsmits. Looks good. I had to replace this pull with a different because I had to add some housekeeping to the code and could not push to your repo. #92

Where should I put the .md files, and what should it contain? Btw, the guidelines are in Norwegian, if you miss something specific, please let me know or feel free to add it yourself.

We probably have to restructure this repo if we make a CI/CD pipeline for the buildprocess using Shorthand and IG-Publisher. But for now you can put it in the ImplementationGuide folder (empty so it's invisible on GitHub).