HL7Norway / basisprofiler-r4

HL7 FHIR Base profiles for Norway - R4
https://simplifier.net/guide/no-basis-entities-individuals
17 stars 2 forks source link

no-basis-procedure after TSC #92

Closed thomiz closed 2 years ago

thomiz commented 2 years ago

Housekeeping

closes #77 closes #82 #83

thomiz commented 2 years ago

This profile is defined as an abstract profile, is there any reasoning for this @mmsmits?

There are no other abstract profiles as part of no-basis.

thomiz commented 2 years ago

The validator reports the code for performer in the example as an error, but it exists in the Norwegian version of snomedct. Unfortunately the validator don't check this (only the latest international version). The code is not available in the international version.

<system value="http://snomed.info/sct"/>
<code value="8921000202108"/>
<display value="Primary performing endoscopist (person)"/>
mmsmits commented 2 years ago

This profile is defined as an abstract profile, is there any reasoning for this @mmsmits?

There are no other abstract profiles as part of no-basis.

No reason, that was copied over from our colonoscopy project. Good catch :)

mmsmits commented 2 years ago

The validator reports the code for performer in the example as an error, but it exists in the Norwegian version of snomedct. Unfortunately the validator don't check this (only the latest international version). The code is not available in the international version.

<system value="http://snomed.info/sct"/>
<code value="8921000202108"/>
<display value="Primary performing endoscopist (person)"/>

Do you want to pick another code? We can also just remove the role entirely. Since it's not a specific constraint of the no-basis profile

thomiz commented 2 years ago

The validator reports the code for performer in the example as an error, but it exists in the Norwegian version of snomedct. Unfortunately the validator don't check this (only the latest international version). The code is not available in the international version.

<system value="http://snomed.info/sct"/>
<code value="8921000202108"/>
<display value="Primary performing endoscopist (person)"/>

Do you want to pick another code? We can also just remove the role entirely. Since it's not a specific constraint of the no-basis profile

I think we should keep it to make the example more complete.

My note is more for documentation of what errors we had and the reason for them. This is'nt really an error at all, but I don't know how to get the validator to make the lookup on the Norwegian specific edition of snomedct or on the more general edition containing all national defintions in addition to the international edition.

mmsmits commented 2 years ago

The validator reports the code for performer in the example as an error, but it exists in the Norwegian version of snomedct. Unfortunately the validator don't check this (only the latest international version). The code is not available in the international version.

<system value="http://snomed.info/sct"/>
<code value="8921000202108"/>
<display value="Primary performing endoscopist (person)"/>

Do you want to pick another code? We can also just remove the role entirely. Since it's not a specific constraint of the no-basis profile

I think we should keep it to make the example more complete.

My note is more for documentation of what errors we had and the reason for them. This is'nt really an error at all, but I don't know how to get the validator to make the lookup on the Norwegian specific edition of snomedct or on the more general edition containing all national defintions in addition to the international edition.

I really don't know either, but I think eHelse is working on a SNOMED terminology service are they not? Should be able to plug that into the java validator, but I'm not really familiar with the java stuff.

thomiz commented 2 years ago

I think we should keep it to make the example more complete. My note is more for documentation of what errors we had and the reason for them. This is'nt really an error at all, but I don't know how to get the validator to make the lookup on the Norwegian specific edition of snomedct or on the more general edition containing all national defintions in addition to the international edition.

I really don't know either, but I think eHelse is working on a SNOMED terminology service are they not? Should be able to plug that into the java validator, but I'm not really familiar with the java stuff.

I think this has been discussed on the fhir chat, have to look into that. Forgot to wait for the .md files (documentation), will make another feature branch for that part, or do you prefer to add the documentation directly to the IG? @mmsmits SIMPLIFIER no-basis IG

mmsmits commented 2 years ago

Directly to the IG would be better. Thanks!

thomiz commented 2 years ago

Made a skeleton page in the guide, just elaborate on that one (just needs som introductory text) I will invite you as soon as possible.

mmsmits commented 2 years ago

Thanks! My simplifier account is under my other email address: m.smits (at) furore.com