search

HLCaptain / proto-shape

Godot engine plugin for rapid prototyping.
MIT License
47 stars 2 forks source link

Automatically add ramp collision on stairs #3

Open ghost opened 1 year ago

ghost commented 1 year ago

In my ignorance, I'm not sure if this feature currently exists. While it allows you to enable the "use collisions" check for the CSG node, it doesn't seem to automatically generate functional collision for vertical movement.

When using the plugin, I've had to manually create ramp collisions. It would be a valuable addition if this could be done automatically, generating and adapting collision shapes to the slope.

This would save a significant amount of time and result in functional stairs quickly.

If I find time I might take a look at it myself and open pull request for you.

Thanks in advance

HLCaptain commented 1 year ago

Sure, let me know your changes. Will probably add a CONTRIBUTING.md soon to the repository, to help you make changes properly besides the contributing chapter in README.md.

HLCaptain commented 8 months ago

Hi, I checked the collisions and behavior looks pretty expected to me. I used the basic collisions from the CSG nodes to do that and it works great. Tried out with a built in prototype map of mine, which I think is available on the master branch as well in prototype_scene.tscn.

While standard stairs are blocky by design, they have blocky collision boxes and not a ramp. This library aims to provide tools for prototyping first and not focusing on polish and design. Basically, you get what you see. So use a ramp and not stairs in this case.

farfalk commented 8 months ago

Mhm, I think that experimenting with correct player navigation is part of level prototyping, so I think this should be supported.

For the time being, though, it should be possible to combine (with a CSGCombiner) a stair with opaque material and no collision with a ramp of transparent material and collisions to achieve what is discussed here

HLCaptain commented 8 months ago

Oh yeah, good idea. Unfortunately ramps in Stair mode are kind of a hack, as they are multiple CSGBoxes with a tiny hole between them to avoid buggy merging, so that should be taken cared of. Probably the user should use the Ramp type in this case, but then it cannot create the Ramp with a hole under it. Fortunately that might be an easy fix because we are using CSG.

farfalk commented 8 months ago

Oh yeah, good idea. Unfortunately ramps in Stair mode are kind of a hack, as they are multiple CSGBoxes with a tiny hole between them to avoid buggy merging, so that should be taken cared of. Probably the user should use the Ramp type in this case, but then it cannot create the Ramp with a hole under it. Fortunately that might be an easy fix because we are using CSG.

I just had another idea, we probably could build a collision polygon with the vertices of the bounding box to get a ramp collider with stairs. Gonna experiment it