HLFH / automua

automua: Email client configuration made easy
GNU General Public License v3.0
5 stars 1 forks source link

Remove dependency on mysqlclient #13

Closed mss closed 1 year ago

mss commented 1 year ago

mysqlclient is just one possible backend for SQLAlchemy and requires various native build stuff to be installed. Since it is possible to use automua with PyMySQL or completely different databases as well it shouldn't be a hard dependency.

HLFH commented 1 year ago

Hi,

Thanks! I'll look into it ASAP.

HLFH commented 1 year ago

@mss Thanks for your suggestion to remove mysqlclient as dep!

The 2023.0 release has been submitted on Pypi, on Arch Linux and on GitHub. It has removed mysqlclient as a dependency. I have also updated automatically the *.txt files with pip-compile, updated the resolver to backtracking, and updated the deps.

HLFH commented 1 year ago

mysqlclient has been added as optdepend. https://github.com/HLFH/automua/commit/d80527d81cc2aabddca99868e899fe4afb2f69fc

mss commented 1 year ago

@HLFH thanks for applying this!

Regarding your comments to the requirements.txt files: I actually used pip-compile to generate them. I guess I used a different version than yours which changed those comments.