search

HMCL-dev / HMCL

A Minecraft Launcher which is multi-functional, cross-platform and popular
https://hmcl.huangyuhui.net
GNU General Public License v3.0
6.9k stars 675 forks source link

[Bug] 调整下载并发数时崩溃 #2740

Closed xiaobaicai2019 closed 8 months ago

xiaobaicai2019 commented 8 months ago

平台 | Platform

Windows11

问题描述 | Problem Description

调整下载并发数时崩溃

启动器崩溃报告 / 启动器日志文件 | Launcher Crash Report / Launcher Log File

---- Hello Minecraft! Crash Report ---- Version: 3.5.5 Time: 2024-02-05 12:55:38 Thread: Thread[JavaFX Application Thread,5,main]

Content: java.lang.IllegalArgumentException at java.base/java.util.concurrent.ThreadPoolExecutor.setCorePoolSize(ThreadPoolExecutor.java:1545) at org.jackhuang.hmcl.task.FetchTask.setDownloadExecutorConcurrency(FetchTask.java:305) at org.jackhuang.hmcl.setting.DownloadProviders.lambda$static$0(DownloadProviders.java:89) at org.jackhuang.hmcl.ui.FXUtils.lambda$observeWeak$3(FXUtils.java:139) at javafx.base@19.0.2.1/javafx.beans.WeakInvalidationListener.invalidated(WeakInvalidationListener.java:83) at javafx.base@19.0.2.1/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:348) at javafx.base@19.0.2.1/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) at javafx.base@19.0.2.1/javafx.beans.property.IntegerPropertyBase.fireValueChangedEvent(IntegerPropertyBase.java:107) at javafx.base@19.0.2.1/javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:114) at javafx.base@19.0.2.1/javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:148) at org.jackhuang.hmcl.ui.main.DownloadSettingsPage.lambda$new$4(DownloadSettingsPage.java:145) at javafx.base@19.0.2.1/com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:360) at javafx.base@19.0.2.1/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80) at javafx.base@19.0.2.1/javafx.beans.property.DoublePropertyBase.fireValueChangedEvent(DoublePropertyBase.java:107) at javafx.base@19.0.2.1/javafx.beans.property.DoublePropertyBase.markInvalid(DoublePropertyBase.java:114) at javafx.base@19.0.2.1/javafx.beans.property.DoublePropertyBase.set(DoublePropertyBase.java:148) at javafx.controls@19.0.2.1/javafx.scene.control.Slider.setValue(Slider.java:209) at javafx.controls@19.0.2.1/com.sun.javafx.scene.control.behavior.SliderBehavior.thumbDragged(SliderBehavior.java:136) at javafx.controls@19.0.2.1/javafx.scene.control.skin.SliderSkin.lambda$initialize$14(SliderSkin.java:394) at javafx.base@19.0.2.1/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86) at javafx.base@19.0.2.1/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234) at javafx.base@19.0.2.1/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at javafx.base@19.0.2.1/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at javafx.base@19.0.2.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at javafx.base@19.0.2.1/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at javafx.base@19.0.2.1/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54) at javafx.base@19.0.2.1/javafx.event.Event.fireEvent(Event.java:198) at javafx.graphics@19.0.2.1/javafx.scene.Scene$MouseHandler.process(Scene.java:3894) at javafx.graphics@19.0.2.1/javafx.scene.Scene.processMouseEvent(Scene.java:1887) at javafx.graphics@19.0.2.1/javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2620) at javafx.graphics@19.0.2.1/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:411) at javafx.graphics@19.0.2.1/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:301) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at javafx.graphics@19.0.2.1/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(GlassViewEventHandler.java:450) at javafx.graphics@19.0.2.1/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:424) at javafx.graphics@19.0.2.1/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:449) at javafx.graphics@19.0.2.1/com.sun.glass.ui.View.handleMouseEvent(View.java:551) at javafx.graphics@19.0.2.1/com.sun.glass.ui.View.notifyMouse(View.java:937) at javafx.graphics@19.0.2.1/com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at javafx.graphics@19.0.2.1/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184) at java.base/java.lang.Thread.run(Thread.java:833)

-- System Details -- Operating System: Windows 11 10.0.22635.2921 System Architecture: amd64 Java Architecture: amd64 Java Version: 17.0.5, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation JVM Max Memory: 4242538496 JVM Total Memory: 167772160 JVM Free Memory: 16020088

burningtnt commented 8 months ago

你是调整到负值了吗？还是调整的太大了

xiaobaicai2019 commented 8 months ago

你是调整到负值了吗？还是调整的太大了

拖动时崩溃

burningtnt commented 8 months ago

拖动时崩溃

无法于 PR Collection 复现，请在你拖动截个图

xiaobaicai2019 commented 8 months ago

image 并且如果不放开左键会一直弹出崩溃日志窗口

xiaobaicai2019 commented 8 months ago

拖动时崩溃

复现步骤

  1. 打开启动器
  2. 下载任意资源包
  3. 拖动下载并发数
burningtnt commented 8 months ago

感谢您的反馈，已记录