search

HMI-Studios / CivCloneJS

3 stars 1 forks source link

Make exportGame safe #145

Open kjniemela opened 1 year ago

kjniemela commented 1 year ago

The exportGame action currently gives the caller all the information about the game, including information that that player shouldn't have access to. This could conceivably be used by an alt client to gather unfair information about the game.

kjniemela commented 10 months ago

@JoelNiemela Honestly, I feel like this just means exportGame shouldn't exist, since there's no meaningful way of exporting and saving a game in progress without being sent information that you shouldn't have access to. Unless we somehow encrypt that data? But that really feels like overkill.