search

HMIProject / open62541

9 stars 6 forks source link

Add wrapper for `BrowsePath`, `BrowsePathResult`, `BrowsePathTarget` and `RelativePath` #132

Closed LeanderGlanda closed 2 months ago

LeanderGlanda commented 2 months ago

This PR requires #130.

LeanderGlanda commented 2 months ago

Is it okay like this or should I split all the three types into different commits or pull requests?

LeanderGlanda commented 2 months ago

I removed the _new and _init methods and changed the methods for setting/initializing to have a with_ prefix.

LeanderGlanda commented 2 months ago

I rebased onto main.

LeanderGlanda commented 2 months ago

The changes look good. Everything should now be changed accordingly. I also tested compatibility with #126 (works as expected with minor expected modifications).

LeanderGlanda commented 2 months ago

Thanks, no problem. It's always a good idea to write clean code, and as I'm not that experienced in Rust some ideas/solutions just don't really come to my mind.

The suggested changes are committed now.