search

HMIProject / open62541

11 stars 6 forks source link

Add method `Server::update_certificate()` #140

Closed LeanderGlanda closed 3 months ago

LeanderGlanda commented 3 months ago

Is an example required for this? If so, how would I properly add one?

LeanderGlanda commented 3 months ago

There seems to be a problem with this function: https://github.com/open62541/open62541/issues/6346

I couldn't find much information about this function, neither in the source code, in the documentation or online. What should I do? Close this PR, keep it and add unsafe for now or any other option?

sgoll commented 3 months ago

I couldn't find much information about this function, neither in the source code, in the documentation or online. What should I do? Close this PR, keep it and add unsafe for now or any other option?

In theory, we could keep the method and mark it as unsafe. In practice, however, what would be the circumstances under which the method is safe to call? What should go into the documentation section "Safety"?

It is unclear under which circumstances this method is safe to call. We wish you best of luck.

That doesn't sound very helpful. So, after considering this, I'd suggest not merging the changes for now until we have more information from upstream 😢

LeanderGlanda commented 3 months ago

Should I keep this PR open or close it for now?

LeanderGlanda commented 3 months ago

Btw: Functions like UA_ServerConfig_addSecurityPolicyBasic256 aren't available through the open62541-sys crate. That's probably because it is behind #ifdef UA_ENABLE_ENCRYPTION in the source.

Where should we discuss how to handle this? In the meeting which is currently arranged for monday/tuesday? @sgoll

sgoll commented 3 months ago

Btw: Functions like UA_ServerConfig_addSecurityPolicyBasic256 aren't available through the open62541-sys crate. That's probably because it is behind #ifdef UA_ENABLE_ENCRYPTION in the source.

Where should we discuss how to handle this? In the meeting which is currently arranged for monday/tuesday?

Yes, let's do that. We have basically two options:

  1. Always enable the compile option.
  2. Use a feature flag on the crate.
LeanderGlanda commented 3 months ago

I'll close this as this will not be merged.