HMIS / LSASampleCode

Longitudinal System Analysis (LSA) Sample Code and Documentation
22 stars 10 forks source link

Follow up for #994: LSA CSV Export Temp Tables.zip: sys_Time.csv dates in 2012 year #1011

Closed nataliesus closed 1 year ago

nataliesus commented 2 years ago

Hi @MollyMcEvilley ,

994 was resolved, but the most recent sys_Time.csv has dates in 2012 year again.

image

Could you please take a look?

Thank you! Natalie

nataliesus commented 1 year ago

Hi @MollyMcEvilley ,

Did you have a chance to take a look at dates in 2012 year? These records cause the discrepancy in the system that was developed to compare 2 LSA reports.

Also, there is a difference in HousedDays calculated in our System comparing with LSA Sample Output because of the dates in sys_Time table within [2012-10-01; 2014-09-30]. image

I.e. in tlsa_Household.csv for [HoHID = 90679 & HHType = 1] in our system we have PSHHousedDays = 2922, but in LSA Sample Output PSHHousedDays is 3652. There are several records in tlsa_Household.csv with a similar issue. And it also causes discrepancies in lsa_Household.csv files.

I just want to confirm that 01 Temp Reporting and Reference Tables.sql has a correct calendar start date and this is the only place where 10/1/2012 should not be updated with [report start date] - 7 years (which is a bit tricky because 10/1/2012 was removed from LSA spec):

image

Could you please take a look?

Thank you! Natalie

nataliesus commented 1 year ago

just in case, under #970 @TanyaPieterse asked: Should we change the @start date to also indicate ReportStart - 7 years? but perhaps it was overlooked...

nataliesus commented 1 year ago

Hi @MollyMcEvilley ,

Just in case there are any updates for calendar start date....

nataliesus commented 1 year ago

Hi @MollyMcEvilley ,

Just in case you had a chance to look at [calendar start date] = 10/1/2012 and not [report start date] - 7 years. It causes the discrepancy not only with sys_Time.csv but also with [PSHHousedDays] column for tlsa_Household.csv and lsa_Household.csv...

nataliesus commented 1 year ago

Hi @MollyMcEvilley , @kiadso ,

Just in case you had time to take a look at this ticket...

MollyMcEvilley commented 1 year ago

Closed by the commit referenced above