search

HMS-Core / hms-react-native-plugin

This repo contains all of React-Native HMS plugins.
https://developer.huawei.com/consumer/en/doc/overview/HMS-Core-Plugin?ha_source=hms1
Apache License 2.0
241 stars 68 forks source link

fix(Android): replace maven with maven-publish for RN +0.67 #199

Closed keremoge closed 2 years ago

keremoge commented 2 years ago

fixing problem: Plugin with id 'maven' not found. related issue: #179

iabadie-dataart commented 2 years ago

Hi @keremoge, Do you know when this change will be published? I need it to upgrade my RN project 🤞

keremoge commented 2 years ago

Hi @keremoge, Do you know when this change will be published? I need it to upgrade my RN project 🤞

Hi @iabadie-dataart, unfortunately I don't know whether this PR will be accepted or not. For now I use patch-package; https://github.com/HMS-Core/hms-react-native-plugin/issues/179#issuecomment-1123622593

eTryp commented 2 years ago

Hi, any update on this PR ? this should me merged, thanks.

iabadie-dataart commented 2 years ago

Hey @ozkulbeng, sorry for the tag. There is some plan in a near future to apply this changes or something like that? Just to know if i should apply the patch-package or I can wait a little bit more for that.

ozkulbeng commented 2 years ago

Hello @iabadie-dataart , @keremoge , We are aware of this issue and planning to solve it in our new releases. But there are different development processes in our team so at this time we can't merge your PR directly, thank you for your contribution.