search

HMS-Core / hms-xamarin-bindings

This repo contains all of Xamarin HMS plugins.
https://developer.huawei.com/consumer/en/doc/overview/HMS-Core-Plugin?ha_source=hms1
Apache License 2.0
36 stars 11 forks source link

[Android] Update PushKit to the latest version and upgrade to AndroidX from Support or remove it completely #11

Open entdark opened 1 year ago

entdark commented 1 year ago

Platform: Android The issue is here: https://github.com/HMS-Core/hms-xamarin-bindings/blob/c77c1bb6a2713671b7ea57365a88651491ea0f92/android/nuspecs/Huawei.Hms.Push.5.0.4.302.nuspec#L17 Push kit bindings contain some helpers that are special addition: https://github.com/HMS-Core/hms-xamarin-bindings/blob/c77c1bb6a2713671b7ea57365a88651491ea0f92/android/source/push/Additions/HMSPush/Util/Utils.cs#L21 Original push kit does not depend on those. So I'd suggest to remove those helpers or move them to another new NuGet. It's up to the final user how to display notifications and we should not depend on Support or AndroidX at all.

xuxiapu commented 1 year ago

@entdark Thanks for your feedback. I suggest you upgrade to version 6.3.0.304 and try again.

entdark commented 1 year ago

I tried the latest version and it depends on Support library. None uses Support libraries anymore.

entdark commented 1 year ago

I literally linked you the place where it is used in the code.

entdark commented 1 year ago

Another example: https://github.com/HMS-Core/hms-xamarin-bindings/blob/main/android/source/push/Additions/HMSPush/LocalNotification/NotificationController.cs#L23

xuxiapu commented 1 year ago

@entdark Thank you for your feedback. We have understood your suggestions and will consider optimization later.

MaximAfanasenko commented 1 year ago

+, package must depend on AndroidX not on Support library

lexboss777 commented 1 year ago

+, I'm also waiting this issue to be resolved