chore: add basic tslint.json integration

HNeukermans / adal-ts

Adal.js typescript rewrite

MIT License

38 stars 21 forks source link

chore: add basic tslint.json integration #23

Closed frederikprijck closed 7 years ago

frederikprijck commented 7 years ago

I'm not sure if you're interested in linting the code. Anyhow, in the PR you can find linting using the basic tslint.json file.

The linter still fails due to alot of code inconsistencies.

If you're interested in the linting integration, I'll be happy to remove the linting warnings/errors and clean up the code accordingly. But maybe make sure the tslint.json file is set as you prefer first.

coveralls commented 7 years ago

Coverage remained the same at 82.746% when pulling a664109a1da9ba447844ff63d77cf0b1fac03bd0 on frederikprijck:chore/tslint into 6bd50e6f48a599518516054768253532fa496209 on HNeukermans:master.

HNeukermans commented 7 years ago

Frederik,

linting is a great idea. I will merge in the basic tslint.json you provided. I'm totally fine to use that as a starting point. Also looking forward to see you having fixed all linting errors, as you have proposed.

Thx, again for the contribution.