search

HNeukermans / adal-ts

Adal.js typescript rewrite
MIT License
38 stars 21 forks source link

chore: add lint to travis #25

Closed frederikprijck closed 7 years ago

frederikprijck commented 7 years ago

I added tslint to travis, failing the build if tslint issues are found. (this currently fails the build because current tslint errors are only fixed once https://github.com/HNeukermans/adal-ts/pull/24 is merged)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 82.746% when pulling 3ab469b4a33143b95a9259fa11f43cbab2ed5128 on frederikprijck:chore/tslint-travis into 62a265d6cc7e50c7178c5db85e70428823b98b11 on HNeukermans:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 82.746% when pulling 842ffb6940cb14c1312898279748fe6ced84a029 on frederikprijck:chore/tslint-travis into 62a265d6cc7e50c7178c5db85e70428823b98b11 on HNeukermans:master.

frederikprijck commented 7 years ago

Keep in mind, violating the tslint configuration does fail the build now. But this should make it easier to ensure PR's are following the projects guidelines.

Btw, thanks for accepting my bunch of PR's :-)