search

HO-CTO / sre-monitoring-as-code

Monitoring-as-Code (MaC) is a jsonnet mixin implementation of SLIs/SLO/Error Budgets using the open-source monitoring and alerting eco-system of Prometheus and Grafana.
https://ho-cto.github.io/sre-monitoring-as-code/
MIT License
23 stars 15 forks source link

393 refine mac public documentation #404

Closed arifulhaqueHO closed 2 years ago

arifulhaqueHO commented 2 years ago

Fixes #393

samiwelthomasHO commented 2 years ago

@arifulhaqueHO probably worth adding the Gemfile.lock into source control too?

georgeowusuHO commented 2 years ago

I am unable to peer review ticket as my local docker middleman doesnt seem to start there is nothing listening on port 4567 after a docker-compose up. I have restarted docker and will do the same with my laptop later.

arifulhaqueHO commented 2 years ago

I am unable to peer review ticket as my local docker middleman doesnt seem to start there is nothing listening on port 4567 after a docker-compose up. I have restarted docker and will do the same with my laptop later.

Are you doing a docker compose build before the run command ?

georgeowusuHO commented 2 years ago

@arifulhaqueHO the pr is blocked due to a change requested by Sam I'm not sure if you have actioned it so it probably best if you check and merge.