search

HOA-2 / SlicerNeuroSegmentation

NeuroSegmentation extension for 3D Slicer
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Improve touch/pen interaction #3

Open Sunderlandkyl opened 5 years ago

Sunderlandkyl commented 5 years ago

To improve the ergonomics and speed of the segmentation process, it is important to develop and test segmentation interactions using touchscreen and pen.

These mostly completed, but they need to be integrated into VTK/Slicer.

In the course of using the interactions, we may also come up with additional ideas for improvements.

Sunderlandkyl commented 5 years ago

Update: The changes required to process touch interactions are still waiting to be integrated in VTK.

While I'm waiting for the integration of the necessary components in VTK, I've begun to put together the neccesary changes for a separate merge request for the pen interactions. This includes an example VTK program using pen interactions. It also allows us to test the pen interactions using the updated version of Qt (5.12+), that we can't currently use in Slicer.

Sunderlandkyl commented 5 years ago

Tested tablet events with Qt 5.13.0

Improvements vs Qt 5.10.1:

Remaining problems in Qt 5.13.0:

Sunderlandkyl commented 5 years ago

Touch interaction changes have been integrated into VTK master (https://github.com/Kitware/VTK/commit/c654847da21dc8ceef224aa8f976a5495b0b7f8d).

Pull request in Slicer updated and pending integration (https://github.com/Slicer/Slicer/pull/1122).

Sunderlandkyl commented 5 years ago

Issue for eraser button events created here: https://bugreports.qt.io/browse/QTBUG-77153

lassoan commented 5 years ago

Pull request in Slicer has been integrated (Slicer/Slicer#1122).

Sunderlandkyl commented 5 years ago

Qt eraser button issue will be fixed in latest version of Qt. Probably 5.14.0 or ~~5.13.1.~~. They've updated the estimates a couple of times now, but it looks like it'll be in 5.13.1.

Sunderlandkyl commented 5 years ago

Hi @jarrett-rushmore,

The necessary components for the tablet events have not been included yet in the latest Slicer release, however I've created a custom installer that includes the additional tablet features so that you can start using and testing them.

The installer can be downloaded here: https://github.com/PerkLab/BwhNeuroImagingCollab/releases/download/v0.1-tablet-mode/Slicer-4.11.0-2019-08-23-win-amd64.exe

Additional information about how to use the tablet mode:

image

  1. Enable/Disable Tablet Mode: In tablet mode, mouse interaction with Segment Editor effects are disabled, and touching the screen with the eraser end of the pen will enable the erase effect.

  2. Pressure Range: For paint and erase effects, the pressure range slider controls how large the brush can grow when applying pressure, relative to the initial brush size. At 0, the brush will remain the same size regardless of how much pressure is applied. At 1, the brush will grow to be 100% larger at maximum pressure.

Let me know if you have any questions.

lassoan commented 5 years ago

Thank you Kyle! For reference, these pull request track the update of Slicer factory machines to use Qt-5.12:

If these are merged then this pen mode should work in regular Slicer builds, too.

jarrett-rushmore commented 5 years ago

Awesome. Thanks, Kyle. I'll keep you posted. J

From: Kyle Sunderland notifications@github.com Sent: Sunday, August 25, 2019 2:38 PM To: PerkLab/BwhNeuroImagingCollab BwhNeuroImagingCollab@noreply.github.com Cc: Rushmore, Richard J rushmore@bu.edu; Mention mention@noreply.github.com Subject: Re: [PerkLab/BwhNeuroImagingCollab] Improve touch/pen interaction (#3)

Hi @jarrett-rushmorehttps://github.com/jarrett-rushmore,

The necessary components for the tablet events have not been included yet in the latest Slicer release, however I've created a custom installer that includes the additional tablet features so that you can start using and testing them.

The installer can be downloaded here: https://github.com/PerkLab/BwhNeuroImagingCollab/releases/download/v0.1-tablet-mode/Slicer-4.11.0-2019-08-23-win-amd64.exe

Additional information about how to use the tablet mode:

[image]https://user-images.githubusercontent.com/9222709/63654173-bdf27d80-c744-11e9-8702-8cf627731c4a.png

  1. Enable/Disable Tablet Mode: In tablet mode, mouse interaction with Segment Editor effects are disabled, and touching the screen with the eraser end of the pen will enable the erase effect.

  2. Pressure Range: For paint and erase effects, the pressure range slider controls how large the brush can grow when applying pressure, relative to the initial brush size. At 0, the brush will remain the same size regardless of how much pressure is applied. At 1, the brush will grow to be 100% larger at maximum pressure.

Let me know if you have any questions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PerkLab/BwhNeuroImagingCollab/issues/3?email_source=notifications&email_token=AMHMRCBGX7NPGVWE6OUR5QDQGLGUHA5CNFSM4H5JB6AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CZJ7Y#issuecomment-524653823, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMHMRCBX7CQP36KJ4BPNXBTQGLGUHANCNFSM4H5JB6AA.