search

HOAIAN2 / Instagram-Downloader

Chrome Extension, download photos, videos from Instagram post, tv, reels, stories
MIT License
144 stars 21 forks source link

Fix mobile UI #2

Closed Kyiro closed 1 year ago

Kyiro commented 1 year ago

This pull request will close #1.

Kyiro commented 1 year ago

I acidentally broke something on chrome by the second commit. Hold on.

HOAIAN2 commented 1 year ago

Ok, still on Lunar New Year vacations but I just check your code, here is something I found.

  1. handleDownload() logic: It's should open display container everytime when user click. When I press download and switch to other post, it's not download it close and I must press again.
  2. Mobile styles is good but display container should have fixed positions because when I scroll down, it's lose.
Kyiro commented 1 year ago

I will fix the first thing you mentioned but the second one only happens on small screens and won't affect desktop. You can see how it looked before in the issue I made.

HOAIAN2 commented 1 year ago

Do you have Instagram? Contact me: hoaian.2202 I will show you styles on mobile. I can't upload video on Github

Kyiro commented 1 year ago

I don't use Instagram much, but you can upload it to a site like imgur or streamable. I do use Discord though: Kyiro#4938

HOAIAN2 commented 1 year ago

I just forgot Google Photos. Check this, scroll down and press Download. https://photos.app.goo.gl/GgihsdTRm4KCx7ULA

Kyiro commented 1 year ago

My bad, I accidentally set the position to be absolute instead of fixed like it is normally

Kyiro commented 1 year ago

It should all be good now