search

HODLERTECH / HODLER-Open-Source-Multi-Asset-Wallet

The Only Open Source Multi-Asset Wallet - Bitcoin (BTC), Bitcoin Cash (BCH), Litecoin (LTC), DASH, Ravencoin (RVN), DigiByte (DGB), Ethereum (ETH) and ERC20 tokens supported
https://hodler.tech
The Unlicense
36 stars 36 forks source link

The format of the master seed is not following BIP39 #151

Open Moller40 opened 5 years ago

Moller40 commented 5 years ago

According to BIP39 the last word should be the checksum, but you ignore this in the code. https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki https://iancoleman.io/bip39/ Also, since there are no checksum it is very easy to write wrong mnemonic words when doing restore. Actually a one word mnemonic seed is accepted, and it most definitely should not. However, like your project!

Fl4reTobiasH commented 5 years ago

Thank you for the suggestion. We plan to introduce the option to choose BIP39 in future releases of the application. Regarding the lack of a checksum in our seed, look at our backups. Almost all are based on encrypted seed and are presented as QR code. This excludes the possibility of a mistake. Greetings!

Moller40 commented 5 years ago

Good that you plan to introduce BIP39! Without it it's hard to verify that the HD addresses are valid (with tools like https://iancoleman.io/bip39/ ) and also very hard to use some other wallet to access the coins in case thats needed. The other backups you have are good, but advanced users should be allowed to verify and restore using BIP39 mnemonic words.