HOL-Theorem-Prover / HOL

Canonical sources for HOL4 theorem-proving system. Branch develop is where “mainline development” occurs; when develop passes our regression tests, master is merged forward to catch up.
https://hol-theorem-prover.org
Other
607 stars 132 forks source link

Monoid theory moved from examples/algebra to src/algebra (core library) #1224

Closed binghe closed 1 month ago

binghe commented 2 months ago

Hi,

The abstract algebra work (under examples/algebra, etc.) by (Joseph) Hing-Lun Chan is an important contribution to HOL4. The present huge PR moves this work (up to monoid, only) into the core library, under a new directory "src/algebra".

Perhaps It's impossible to review all code changes (50k+ additions, 58k- deletions) in the commits. Below is just a summary of ideas behind those changes:

Once the present PR gets merged, the next steps would be moving also the groupTheory and ringTheory, etc. (after theory combinations) to "src/algebra", and then start making connections to other existing theories.

Chun Tian

binghe commented 2 months ago

On a second thought, the name change of SNOC_LAST_FRONT (in listTheory) should be reverted for better backward compatibility (important if this PR is not going to merge before T1 release), and in this way all changes in examples/lambda can be reverted too, reduced the total number of changed lists in the PR branch.

binghe commented 1 month ago

Per our offline discussions, the new files under src/algebra are moved into src/algebra/base (for number, prime and combinatorics) and src/algebra/construction (for monoid and the small jcLib). The directory "src/algebra" itself depends on the two subdirectories and will be reserved for the algebraTheory containing the (combined) type-based algebra formalizations.

mn200 commented 1 month ago

Thanks!