HOLALee / rqalpha-tushare

rqalpha get K data from tushare
2 stars 1 forks source link

Suggest to loosen the dependency on rqalpha #1

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Dear developers,

Your project rqalpha-tushare requires "rqalpha==3.0.0" in its dependency. After analyzing the source code, we found that the following versions of rqalpha can also be suitable without affecting your project, i.e., rqalpha 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.2.4, 2.2.5, 2.2.6, 2.2.7. Therefore, we suggest to loosen the dependency on rqalpha from "rqalpha==3.0.0" to "rqalpha>=2.2.0,<=3.0.0" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on rqalpha?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: 1b168f41c338f6bd9176c32e15808a8d019b9b3e) directly uses 2 APIs from package rqalpha.

rqalpha.interface.AbstractMod.__init__, rqalpha.data.base_data_source.BaseDataSource.__init__

Beginning fromwhich, 18 functions are then indirectly called, including 10 rqalpha's internal APIs and 8 outsider APIs as follows:

[/HOLALee/rqalpha-tushare]
+--rqalpha.interface.AbstractMod.__init__
+--rqalpha.data.base_data_source.BaseDataSource.__init__
|      +--os.path.join
|      +--rqalpha.data.instrument_store.InstrumentStore.__init__
|      |      +--pickle.load
|      |      +--rqalpha.model.instrument.Instrument.__init__
|      |      |      +--rqalpha.model.instrument.Instrument._fix_date
|      |      |      |      +--datetime.datetime
|      +--rqalpha.data.dividend_store.DividendStore.__init__
|      |      +--bcolz.open
|      |      +--numpy.empty
|      |      +--numpy.dtype
|      +--rqalpha.data.trading_dates_store.TradingDatesStore.__init__
|      |      +--pandas.Index
|      |      +--pandas.Timestamp
|      |      +--bcolz.open
|      +--rqalpha.data.yield_curve_store.YieldCurveStore.__init__
|      |      +--bcolz.open
|      +--rqalpha.data.simple_factor_store.SimpleFactorStore.__init__
|      |      +--bcolz.open
|      +--rqalpha.data.date_set.DateSet.__init__
|      |      +--bcolz.open
|      +--rqalpha.data.daybar_store.DayBarStore.__init__
|      |      +--bcolz.open
|      +--rqalpha.utils.i18n.gettext
|      |      +--rqalpha.utils.py2.to_utf8
|      |      |      +--rqalpha.utils.py2.to_utf8

Since all these functions have not been changed between any version for package "rqalpha" from [2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.2.4, 2.2.5, 2.2.6, 2.2.7] and 3.0.0. Therefore, we believe it is safe to loosen the corresponding dependency.

HOLALee commented 1 year ago

邮件已收到,谢谢您的邮件。我会尽快回复您的邮件。祝您生活工作事事顺心,感情工资齐齐致富。                                        李逾中(18923744450)