timestep specification - Githubissues

HPCSys-Lab / simwave

Simulates the propagation of the acoustic wave using the finite difference method in 2D and 3D domains.

GNU General Public License v3.0

40 stars 13 forks source link

Closed krober10nd closed 3 years ago

krober10nd commented 3 years ago

the delta t should be specified in the TimeModel
The delta t is related to the temporal discretization not directly the spatial model. It's a bit non-inutitive to specify the timestep through SpaceModel IMO.

jaimesouza commented 3 years ago

Indeed. I am gonna change that.

jaimesouza commented 3 years ago

jaimesouza commented 3 years ago

Do you think we should define the custom dt in the TimeModel constructor, instead of in a setter function?

krober10nd commented 3 years ago

I think we should have an optional kwarg in the constructor and also a getter and setter method in the TimeModel class.

jaimesouza commented 3 years ago