search

HPCToolkit / hpcviewer.e4

Eclipse 4 version of hpcviewer
Other
9 stars 0 forks source link

Flat view's cost attribution is incorrect in line scopes #223

Open laksono opened 2 years ago

laksono commented 2 years ago

Describe the bug Flat view attribution is incorrect for inline nodes. The exclusive costs of the line statements are bigger than its procedure.

Screenshots image

laksono commented 2 years ago

The main cause of this issue is because the line scopes have exactly the same flat id regardless the procedures. Unfortunately hpcprof2 generated different flat id for the same procedure of the same file. This causes confusion in the flat view.

image

laksono commented 2 years ago

This may be related: using Chombo armGodunov3d database in the flat view, a procedure can contain an inline which has small exclusive cost but its descendants (loops and lines) have high exclusive cost.

image

In this snapshot the inlined procedure [i] memset has exclusive cost 0.4% while in the procedure level it's 11.8%. A loop in the inlined procedure loop at memset.S: 615 has 11.2% of exclusive cost.

blue42u commented 2 years ago

This repository has moved to GitLab, please continue this issue there.